Skip to content

style(codeowners): Update CTA for darkmode #29797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NisanthanNanthakumar merged 1 commit into from
Nov 6, 2021
Merged

style(codeowners): Update CTA for darkmode #29797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/components/group/suggestedOwners/ownershipRules.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const Header = styled('h6')`
`;

const Content = styled('span')`
color: ${p => p.theme.gray500};
color: ${p => p.theme.textColor};
Copy link
Member

@evanpurkhiser evanpurkhiser Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be textColor or subText

Copy link
Contributor Author

@NisanthanNanthakumar NisanthanNanthakumar Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanpurkhiser textColor matches the gray500 for the lightAlias. The design used gray500 for the content.

margin-bottom: ${space(2)};
`;

Expand Down