Skip to content

ref(lpq): Remove per-project ID tagging of metrics #29873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flub merged 1 commit into from
Nov 9, 2021
Merged

ref(lpq): Remove per-project ID tagging of metrics #29873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions src/sentry/tasks/low_priority_symbolication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,11 @@ def excessive_event_rate(project_id: int, event_counts: BucketedCounts) -> bool:
total_rate = event_counts.rate(event_counts.TOTAL_PERIOD)
recent_rate = event_counts.rate(period=60)

metrics.gauge(
"symbolication.lpq.computation.rate.total", total_rate, tags={"project_id": project_id}
)
metrics.gauge(
"symbolication.lpq.computation.rate.recent", recent_rate, tags={"project_id": project_id}
)
# Note, We had these tagged with tags={"project_id": project_id} during our initial
# evaluation, however the cardinality for this is really too high to leave that on
# forever in production.
metrics.gauge("symbolication.lpq.computation.rate.total", total_rate)
metrics.gauge("symbolication.lpq.computation.rate.recent", recent_rate)

if recent_rate > 50 and recent_rate > 5 * total_rate:
return True
Expand All @@ -135,14 +134,11 @@ def excessive_event_duration(project_id: int, durations: BucketedDurationsHistog
return False
events_per_minute = total_histogram.total_count() / (durations.total_time() / 60)

metrics.gauge(
"symbolication.lpq.computation.durations.p75", p75_duration, tags={"project_id": project_id}
)
metrics.gauge(
"symbolication.lpq.computation.durations.events_per_minutes",
events_per_minute,
tags={"project_id": project_id},
)
# Note, We had these tagged with tags={"project_id": project_id} during our initial
# evaluation, however the cardinality for this is really too high to leave that on
# forever in production.
metrics.gauge("symbolication.lpq.computation.durations.p75", p75_duration)
metrics.gauge("symbolication.lpq.computation.durations.events_per_minutes", events_per_minute)

if events_per_minute > 15 and p75_duration > 6 * 60:
return True
Expand Down