feat(leaky-bucket): handle disabled org integrations#30459
Merged
Conversation
added 9 commits
December 1, 2021 15:18
…-disabled-org-integrations
…-disabled-org-integrations
…-disabled-org-integrations
Contributor
Author
|
Need to adjust how the query works |
wedamija
approved these changes
Dec 7, 2021
wedamija
left a comment
wedamija
left a comment
Member
There was a problem hiding this comment.
lgtm, I just quickly validated that your new test fails without the changes and succeeds with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new attempt to merge this PR: #30339 which resulted in an outage (SENTRY-SWS). The commit to fix the issue: 2f0d95a
This PR adds logic to make sure we don't allow users to pick a disabled integration (or org integration) for metric alerts and issue alerts. Additionally, it ensures we don't send issue alerts, metric alerts, or notifications for those disabled integrations. This is being done to make sure when we set the
OrganizationIntegrationstatus to disabled for Slack, alerting and notification get properly disabled.Note, I am purposely not propagating this change for other integration features such as stack trace linking, issue syncing, etc. Since it seems the leaky bucket only impacts alert rule integrations, making those changes isn't strictly necessary to ensure functionality (and could add risk to this PR). Perhaps in a follow-up PR we might extend these checks there.