ref(models): Combine option models into a submodule#31615
Merged
Conversation
mgaeta
force-pushed
the
fix/organization-integrations-6
branch
from
e517b55 to
807a638
Compare
markstory
reviewed
Feb 7, 2022
| src/sentry/models/organizationoption.py, | ||
| src/sentry/models/projectoption.py, | ||
| src/sentry/models/useroption.py, | ||
| src/sentry/models/options/, |
Member
There was a problem hiding this comment.
Another potential location would be with the other options code in sentry.options.models. Although that options and these options serve very different purposes 🤔
Contributor
Author
There was a problem hiding this comment.
Yeah these option models are sort of catch-all settings and the options module is for options that act like environment variables.
mgaeta
force-pushed
the
fix/organization-integrations-6
branch
from
f999195 to
45a4a4d
Compare
mgaeta
force-pushed
the
fix/organization-integrations-6
branch
from
45a4a4d to
f29ba5e
Compare
NisanthanNanthakumar
approved these changes
Feb 11, 2022
mgaeta
force-pushed
the
fix/organization-integrations-6
branch
from
f29ba5e to
7fa7d40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Backend TSC, we decided that it's time to start organizing some of our larger, flat directories. In this PR I take some files that are top-level in the module and combine them into a sub-directory.