feat(profiling): add view select menu #31698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
changed the base branch from
jb/profiling/flamegraph-renderer
to
jb/profiling/tooltip
Contributor
size-limit report
|
JonasBa
force-pushed
the
jb/profiling/tooltip
branch
from
6074494 to
d18d7ae
Compare
JonasBa
force-pushed
the
jb/profiling/flamegraph-view-select
branch
from
f0b49a8 to
cebadfa
Compare
JonasBa
force-pushed
the
jb/profiling/flamegraph-view-select
branch
from
e79b78c to
e1a4630
Compare
Zylphrex
reviewed
Feb 10, 2022
JonasBa
force-pushed
the
jb/profiling/flamegraph-view-select
branch
from
fff0334 to
64af0cd
Compare
Zylphrex
approved these changes
Feb 11, 2022
JonasBa
force-pushed
the
jb/profiling/flamegraph-view-select
branch
from
64af0cd to
d59c70b
Compare
| onSortingChange, | ||
| }: FlamegraphViewSelectMenuProps): React.ReactElement { | ||
| return ( | ||
| <ButtonBar merged> |
Member
There was a problem hiding this comment.
Is the gif outdated? Doesn't look like it's using the button bar
Member
Author
There was a problem hiding this comment.
Yes, indeed, it's outdated!
JonasBa
added a commit
that referenced
this pull request
Feb 15, 2022
* feat(flamegraph): add view select menu * feat(profiling): use buttonbar * fix(viewselectmenu): use locale * test(gridrenderer): update tests
JonasBa
added a commit
that referenced
this pull request
Feb 15, 2022
* feat(profiling): flamegraph * feat(profiling): add flamegraph renderer and tests * fix(profiling): ignore unused renderer in test * fix(profiling): ignore unused renderer in test * feat(profiling): add util hooks * ref(hook): add usememowithprevious tests * feat(profiling): zoom view * fix(flamegraphrenderer): adjust for profiles that do not start at 0 and trim text more accurately * feat(profiling): add tooltip component * fix(flamegraph): remove merge marker * test(utils): fix tests * fix(tooltip): code review * feat(tooltip): add useDevicePixelRatio hook * feat(profiling): add view select menu (#31698) * feat(flamegraph): add view select menu * feat(profiling): use buttonbar * fix(viewselectmenu): use locale * test(gridrenderer): update tests * feat(profiling): add ability to search for frames (#31723) * feat(flamegraph): add view select menu * feat(profiling): use buttonbar * feat(profiling): add search * style(lint): Auto commit lint changes * style(lint): Auto commit lint changes * feat(profiling): decouple search fn * fix(flamegraphsearch): missing hook deps Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> * fix(flamegraphtooltip): update deps Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Zylphrex we may need some smaller buttons 🙈