ref(mep): Some cleanup to the metric query builder#32139
Merged
Conversation
- This adds metric_id to the search conditions based on the aggregates added so that there's a top level filter instead of just the aggregate -if combinator filters. This should help with query performance - This also removes the combinator&merge from query construction since snuba can handle this for us, which makes the functions a bit cleaner
shruthilayaj
approved these changes
Mar 2, 2022
shruthilayaj
left a comment
shruthilayaj
left a comment
Member
There was a problem hiding this comment.
A comment about the count -> value thing but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added so that there's a top level filter instead of just the aggregate
-if combinator filters. This should help with query performance
snuba can handle this for us, which makes the functions a bit cleaner