JavaScript client: changed now-misleading comment#324
Merged
dcramer merged 1 commit intogetsentry:masterfrom Jan 26, 2012
acdha:js-client-comment-cleanup
Merged
JavaScript client: changed now-misleading comment#324dcramer merged 1 commit intogetsentry:masterfrom acdha:js-client-comment-cleanup
dcramer merged 1 commit intogetsentry:masterfrom
acdha:js-client-comment-cleanup
Conversation
The state of WebKit error handling has improved nicely since I wrote this code for Arecibo
dcramer
added a commit
that referenced
this pull request
Jan 26, 2012
JavaScript client: changed now-misleading comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment was true when I wrote the first version of the window.onerror handler but is no longer true for current versions of Chrome and Safari. Seems like a good idea to avoid confusing anyone.