Remove insecure fallback system.secret-key#3268
Merged
mattrobenolt merged 1 commit intomasterfrom May 19, 2016
Merged
Conversation
Contributor
|
Ship it! |
Having a fallback here makes it significantly more likely for two installs to be sharing the same value, which would be highly insecure. Removing this fallback makes it mandatory to define in your own config. Also enforce strictly and yield a useful error message on how to correct the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a fallback here makes it significantly more likely for two
installs to be sharing the same value, which would be highly insecure.
Removing this fallback makes it mandatory to define in your own config.
Also enforce strictly and yield a useful error message on how to correct
the issue.
@getsentry/infrastructure