feat(dam): Expose derived metrics in dashboards#32798
Conversation
size-limit report 📦
|
shruthilayaj
changed the title
| if ( | ||
| column.kind === 'field' || | ||
| column.kind === 'equation' || | ||
| column.kind === 'calculatedField' |
There was a problem hiding this comment.
nit: Should we use FieldValueKind.FIELD and FieldValueKind.EQUATION and add calculatedField to FieldValueKind?
There was a problem hiding this comment.
I'll do this and the comment below in a follow up (it's a bigger change and causes a lot of ts errors)!
There was a problem hiding this comment.
Ok @edwardgou-sentry actually I'm going to make a ticket and kick this can to when we clean up tech debt 😛
There was a problem hiding this comment.
Also I don't know that making these enums provides us with much benefit? Enums might just increase the size of the transpiled code?
| } | ||
| | { | ||
| field: string; | ||
| kind: 'calculatedField'; |
There was a problem hiding this comment.
nit: maybe not within scope of this pr either but I think we can probably also use the FieldValueKind enum here
edwardgou-sentry
left a comment
edwardgou-sentry
left a comment
There was a problem hiding this comment.
Looks good to me! The other comments are definitely nits and not blockers
3 participants
Add support for derived metrics in Dashboards.