feat(new-widget-builder-experience): Add support to the release data set in SortBy - Part 2 - [DD-537]#33241
Merged
priscilawebdev merged 16 commits intomasterfrom Apr 6, 2022
Conversation
priscilawebdev
changed the base branch from
master
to
feat/new-widget-builder-experience-add-metrics-data-set
priscilawebdev
changed the title
priscilawebdev
changed the title
…' into feat/new-widget-builder-experience-add-metrics-data-set-part-2
5 tasks
Base automatically changed from
feat/new-widget-builder-experience-add-metrics-data-set
to
master
April 5, 2022 06:24
…rics-data-set-part-2
narsaynorath
approved these changes
Apr 5, 2022
Member
narsaynorath
left a comment
narsaynorath
left a comment
There was a problem hiding this comment.
Looks good. I checked its behaviour with the modal and it behaves the same way 👍
|
|
||
| return ( | ||
| <StyledIssueListSearchBar | ||
| searchSource={searchSource} |
Member
There was a problem hiding this comment.
Do we want to remove this now? This component is still being used in the modal to avoid having duplicate logic and I figured we'd make this change when we delete that
Member
Author
There was a problem hiding this comment.
oh, I see...yes it's better to not change this now.. will revert it ..thanks
| widgetType={widgetType} | ||
| sortByOptions={ | ||
| dataSet === DataSet.EVENTS | ||
| dataSet !== DataSet.ISSUES |
Member
There was a problem hiding this comment.
I'm thinking we should make this dataSet === DataSet.Issues and flip the ternary results like we did in widgetBuilder/utils.tsx. Not a big deal but it's consistent and I think positive checks are nice
…rics-data-set-part-2
priscilawebdev
deleted the
feat/new-widget-builder-experience-add-metrics-data-set-part-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-04-03.at.18.19.01.mov