Skip to content

ref(new-widget-builder-experience): Revert MetricsSearchbar logic#33303

Merged
priscilawebdev merged 2 commits intomasterfrom
ref/new-widget-builder-experience-put-pack-metrics-search-bar-logic
Apr 5, 2022
Merged

ref(new-widget-builder-experience): Revert MetricsSearchbar logic#33303
priscilawebdev merged 2 commits intomasterfrom
ref/new-widget-builder-experience-put-pack-metrics-search-bar-logic

Conversation

@priscilawebdev
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev commented Apr 5, 2022

Revert changes made to the MetricsSearchBar in the PR #33047

Copy link
Copy Markdown
Member

@shruthilayaj shruthilayaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this so that the page doesn't crash. But it seems like fields and tags are no longer being populated in the column selectors (screenshot is on dev-ui) 👀
Screen Shot 2022-04-05 at 9 44 14 AM

@priscilawebdev
Copy link
Copy Markdown
Member Author

@shruthilayaj do you have all conditions passing?

 organization.features.includes('dashboards-metrics') &&
      !organization.features.includes('new-widget-builder-experience') &&
      organization.features.includes('new-widget-builder-experience-modal-access')

@shruthilayaj
Copy link
Copy Markdown
Member

@shruthilayaj do you have all conditions passing?

 organization.features.includes('dashboards-metrics') &&
      !organization.features.includes('new-widget-builder-experience') &&
      organization.features.includes('new-widget-builder-experience-modal-access')

I think these should be populated if I just have dashboards-metrics enabled though (which I do)

@priscilawebdev
Copy link
Copy Markdown
Member Author

priscilawebdev commented Apr 5, 2022

@shruthilayaj I removed that because wanted to avoid having to fetch the same thing 2x, but I think it's fine to leave it for now. I've updated the logic

@priscilawebdev priscilawebdev merged commit 22fb095 into master Apr 5, 2022
@priscilawebdev priscilawebdev deleted the ref/new-widget-builder-experience-put-pack-metrics-search-bar-logic branch April 5, 2022 14:21
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants