Access control#340
Merged
dcramer merged 5 commits intogetsentry:masterfrom Feb 6, 2012
lincolnloop:access-control
Merged
Conversation
sentry/utils/http.py
Outdated
Member
There was a problem hiding this comment.
Can we put a default in the "defaults.py" file, then we dont have to use getattr here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the SENTRY_ALLOW_ORIGIN setting, which will set Access-Control-Allow-Origin and Access-Control-Allow-Headers on the /api/store/ url to allow cross-domain requests. This enables JavaScript cross-domain error reporting without having to deal with jsonp.
Setting SENTRY_ALLOW_ORIGIN to "*" will allow cross-domain requests from any domain.
Setting SENTRY_ALLOW_ORIGIN to a specific domain will only allow cross-domain requests from that domain.
https://developer.mozilla.org/En/HTTP_access_control#Simple_requests
This also fixes a minor bug in
_get_rendered_interfaces()which will cause it to error out if there is a problem with interface.to_html(), since thehtmlvariable is not defined in that case.