ref(replays): Remove extra "retry" state from useReplayData#34910
Merged
Conversation
ryan953
force-pushed
the
ryan953/useReplayData-retry-cleanup
branch
from
ced85bb to
f0bf1a3
Compare
ryan953
force-pushed
the
ryan953/useReplayData-retry-cleanup
branch
from
f0bf1a3 to
94ac697
Compare
billyvg
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
retrystate variable, we can simply passloadEventson down so children can load more data.Setting the var was one way to debounce calls to
onRetry, but really children can look at thefetchingvar to know if they should be callingonRetryor not at any given time.loadEventscould also look atfetchingand have a guard, but none of this downstream stuff matters now anyway because nothing is misbehaving right now.