ref: git mv tests/fixtures fixtures#35445
Merged
asottile-sentry merged 2 commits intomasterfrom Jun 8, 2022
Merged
Conversation
asottile-sentry
force-pushed
the
asottile-fixtures
branch
2 times, most recently
from
9ca4395 to
e7c4c63
Compare
asottile-sentry
force-pushed
the
asottile-fixtures
branch
from
564fb89 to
2085f94
Compare
Contributor
size-limit report 📦
|
asottile-sentry
force-pushed
the
asottile-fixtures
branch
from
44a9407 to
77c3a7b
Compare
asottile-sentry
force-pushed
the
asottile-fixtures
branch
from
77c3a7b to
3e123ee
Compare
asottile-sentry
force-pushed
the
asottile-fixtures
branch
from
3e123ee to
82aaa49
Compare
asottile-sentry
commented
Jun 7, 2022
| @@ -0,0 +1 @@ | |||
| ../fixtures No newline at end of file | |||
Contributor
Author
There was a problem hiding this comment.
this is a (temporary) symlink -- some stuff in getsentry hardcodes tests/fixtures and I'll have to fix those in a 3-step process
asottile-sentry
commented
Jun 7, 2022
| from tests.sentry.api.endpoints.test_user_authenticator_details import assert_security_email_sent | ||
|
|
||
|
|
||
| # TODO(joshuarli): move all fixtures to a standard path relative to gitroot, |
joshuarli
reviewed
Jun 7, 2022
| "fixtures", | ||
| name, | ||
| ) | ||
| def get_fixture_path(*parts: str) -> str: |
Member
There was a problem hiding this comment.
What wasn't correct or optimal about this previously? Just curious.
Contributor
Author
There was a problem hiding this comment.
it left a bunch of ..s in the path, the path wasn't absolute so it could potentially cut off the root early, and it had the old path
joshuarli
reviewed
Jun 7, 2022
| @@ -5,7 +5,7 @@ exclude: > | |||
| \.map$| | |||
| \.map\.js$| | |||
| ^tests/sentry/lang/.*/fixtures/| | |||
Member
There was a problem hiding this comment.
This path matches nothing anymore, can remove.
Contributor
Author
There was a problem hiding this comment.
sweet, will do in a followup!
joshuarli
reviewed
Jun 7, 2022
Member
joshuarli
left a comment
joshuarli
left a comment
There was a problem hiding this comment.
Looks like you missed some dirs?
tests/integration/fixtures
tests/relay_integration/lang/javascript/fixtures
tests/sentry/models/fixtures
Contributor
Author
yeah, I'm doing things one at a time |
joshuarli
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm moving test code which isn't tests to fixtures/ so I can enforce a naming convention for python test files
this is part of https://getsentry.atlassian.net/browse/DEVINFRA-43