Improvements to security flows#3646
Merged
Merged
Conversation
Member
Author
|
Mostly a followup with more iteration since just requiring password on password change isnt enough to prevent account hijack. |
dcramer
force-pushed
the
security-improvements
branch
from
bf85ee8 to
2f56f5e
Compare
Contributor
There was a problem hiding this comment.
should this not be outdented?
dcramer
force-pushed
the
security-improvements
branch
from
2f56f5e to
d212000
Compare
Contributor
There was a problem hiding this comment.
actually now that it's outdented i wonder why needs_password is not true by default.
Member
Author
There was a problem hiding this comment.
We only need to verify your current email if you can change your password or email address. If the email field is managed, we dont need to verify password.
- Move mfa to Security settings under account - Require password confirmation on email change - Improve managed user flows - Remove feature flag for mfa - Remove sudo on various account settings /cc @getsentry/infrastructure @getsentry/security
dcramer
force-pushed
the
security-improvements
branch
from
d212000 to
1cdd20c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @getsentry/infrastructure @getsentry/security
This change is