Skip to content

feat(dashboards): Metric Widgets use units provided from events request meta#36950

Merged
edwardgou-sentry merged 2 commits into
masterfrom
feat/cm-widget-use-units
Jul 25, 2022
Merged

feat(dashboards): Metric Widgets use units provided from events request meta#36950
edwardgou-sentry merged 2 commits into
masterfrom
feat/cm-widget-use-units

Conversation

@edwardgou-sentry

@edwardgou-sentry edwardgou-sentry commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Updates Discover Table and Big Number charts to use duration and size units from events request meta when rendering values.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 21, 2022
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 62.99 KB (+0.05% 🔺)
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.87 KB (0%)

@wmak wmak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardgou-sentry edwardgou-sentry merged commit de40e67 into master Jul 25, 2022
@edwardgou-sentry edwardgou-sentry deleted the feat/cm-widget-use-units branch July 25, 2022 13:47
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants