Skip to content

fix(alerts): Display event frequency conditions as text#37061

Merged
scttcper merged 2 commits into
masterfrom
scttcper/percentage-filters
Jul 26, 2022
Merged

fix(alerts): Display event frequency conditions as text#37061
scttcper merged 2 commits into
masterfrom
scttcper/percentage-filters

Conversation

@scttcper

@scttcper scttcper commented Jul 26, 2022

Copy link
Copy Markdown
Member

On the issue alert details page we were displaying the event frequency condition as its rendered from the backend, this was confusing.

given the following alert - the alert details page was confusing
image

before
Screen Shot 2022-07-26 at 10 26 52 AM

after
Screen Shot 2022-07-26 at 10 06 20 AM

fixes https://getsentry.atlassian.net/browse/FEEDBACK-1531

On the issue alert details page we were displaying the event frequency condition as its rendered from the backend, this was confusing.
@scttcper scttcper requested review from a team and davidenwang July 26, 2022 17:33
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 26, 2022
@scttcper scttcper changed the title fix(alerts): Display event frequency conditions as text correctly fix(alerts): Display event frequency conditions as text Jul 26, 2022
@scttcper scttcper merged commit 107c9a4 into master Jul 26, 2022
@scttcper scttcper deleted the scttcper/percentage-filters branch July 26, 2022 21:38
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants