feat(sampling): Add specify client modal - [TET-279]#37251
Conversation
github-actions
Bot
added
the
Scope: Frontend
|
@priscilawebdev I noticed, some Can you use the below modal as the point of truth for adjusting the |
|
@Jesse-Box good catch... that's because I defined it as a label of the input and not a TextBlock... will update it |
priscilawebdev
changed the title
matejminar
left a comment
matejminar
left a comment
There was a problem hiding this comment.
Can you double-check this pls?
Kapture.2022-08-01.at.15.50.33.mp4
thank you! Issue shall be fixed now... good catch |
|
BTW when they are editing the uniform rule and discard is not present in the outcome data... shall we display the "0" step? maybe we can discuss this offline |
| if (activeStep === Step.SET_CURRENT_CLIENT_SAMPLE_RATE) { | ||
| return ( | ||
| <SpecifyClientRateModal | ||
| {...props} | ||
| Header={Header} | ||
| Body={Body} | ||
| Footer={Footer} | ||
| closeModal={closeModal} | ||
| onReadDocs={onReadDocs} | ||
| organization={organization} | ||
| projectId={project.id} | ||
| onGoNext={value => { | ||
| setSpecifiedClientRate(Number(value)); | ||
| setActiveStep(Step.SET_UNIFORM_SAMPLE_RATE); | ||
| }} | ||
| /> | ||
| ); |
There was a problem hiding this comment.
I've noticed one more bug.
If we hit back on the uniform rate modal the client rate is lost.
How about we keep it in a state of the uniformRateModal and pass it as props to the SpecifyClientRateModal (and updater function too)? We could remove the useState from the SpecifyClientRateModal and the value would be remembered when going back and forth between modals.
There was a problem hiding this comment.
good catch...thanks
priscilawebdev
deleted the
feat/sampling-add-specificy-current-client-sample-rate
branch
3 participants
What this PR does:
What will be done in a follow-up:
Preview: