feat(auditlog): Remove versioning from endpoint #37301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
vbro
approved these changes
Aug 2, 2022
maheskett
approved these changes
Aug 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to supply the list of audit log event api names to the audit log frontend view (to replace hard-coding updates), a version 2 query parameter was temporarily added to the requests. This ensured the endpoint would provide the api names list to only requests that included
"version":"2"in the query.Removing this condition so that all requests to the endpoint provide both
rowsof the audit log entries andoptionsof the api names.Confirmed that requests to the endpoint have included the
"version":"2"query parameter, and its removal will not impact users.