feat(auditlog): Remove version from query payload #37303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
markstory
reviewed
Aug 3, 2022
| })); | ||
| browserHistory.push({ | ||
| pathname: location.pathname, | ||
| search: `?event=${value}`, |
There was a problem hiding this comment.
I think you also need to initialize the state based on the location state. Without that you could load the incorrect results after a page reload.
markstory
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Do you still need this parameter? It looks like it is unused.
mbauer404
force-pushed
the
mbauer404/remove-versioning-from-request
branch
from
8cf741a to
413fd66
Compare
vbro
approved these changes
Aug 8, 2022
mbauer404
force-pushed
the
mbauer404/remove-versioning-from-request
branch
from
413fd66 to
bb87a45
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires sentry#37301
Removes the
version:2query from the request payload. The versioning was a temporary update to allow the audit log endpoint to add the audit log api names list to be included in the api response.Also adds
browserHistorywhen filtering by an audit log event type to aid in sharing URL links to a filtered view of the audit log event entries.