chore(auth): Update sentry.identity.oauth2 to support customer domains#38973
Closed
chore(auth): Update sentry.identity.oauth2 to support customer domains#38973
Conversation
github-actions
bot
added
the
Scope: Backend
dashed
force-pushed
the
hybrid-cloud/2-oauth2-customer-domains
branch
from
3cef0f2 to
78a75a3
Compare
Base automatically changed from
hybrid-cloud/1-oauth2-customer-domains
to
master
September 16, 2022 22:18
Member
Author
|
I'm closing this as I will delegate the per-request callback URL to the "state" parameter. I've implemented this in #39016 for another OAuth2 provider implementation, and I'll do the same for the OAuth2 provider in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #38970
This is a first pass in updating
sentry.identity.oauth2to support customer domains.The motivation is to add SSO support for customer domains by dynamically update
redirect_uriattributes with the appropriate hostname.This is not to be confused with #38970, I intentionally separated out the changes so that it's easier to review.