Merged
Conversation
github-actions
bot
added
the
Scope: Backend
asottile-sentry
force-pushed
the
asottile-upgrade-protobuf
branch
from
fcd8188 to
cb5e275
Compare
asottile-sentry
force-pushed
the
asottile-upgrade-protobuf
branch
from
cb5e275 to
97dab48
Compare
asottile-sentry
force-pushed
the
asottile-upgrade-protobuf
branch
from
97dab48 to
c7d48c8
Compare
asottile-sentry
force-pushed
the
asottile-upgrade-protobuf
branch
from
c7d48c8 to
3976828
Compare
asottile-sentry
force-pushed
the
asottile-upgrade-protobuf
branch
from
3976828 to
291c0f1
Compare
JoshFerge
reviewed
Oct 4, 2022
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
looks ok. i think we should have someone from ingest and whoever owns the metrics piece take a look and be around when this goes out -- there are a lot of upgrades to google libraries here that could affect our ingest paths.
flub
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for dependabot here: https://github.com/getsentry/getsentry/pull/8387