fix(gitlab): Fix AppPlatformEvents hitting Gitlab webhook endpoint#39333
Merged
Conversation
It seems that AppPlatformEvents hits the Gitlab webhook [1] and it does not contain the Gitlab headers. This regression was introduced via #39129. Fixes [SENTRY-W3G](https://sentry.io/organizations/sentry/issues/3624081212/?project=1) [1] https://github.com/getsentry/sentry/blob/07362b7d8eb6b03acc21aafb91e58a1865c00da3/src/sentry/api/serializers/models/app_platform_event.py#L46-L55
github-actions
Bot
added
the
Scope: Backend
snigdhas
approved these changes
Sep 27, 2022
ryan953
pushed a commit
that referenced
this pull request
Oct 3, 2022
…39333) It seems that AppPlatformEvents hits the Gitlab webhook [1] and it does not contain the Gitlab headers. This regression was introduced via #39129. Fixes [SENTRY-W3G](https://sentry.io/organizations/sentry/issues/3624081212/?project=1) [1] https://github.com/getsentry/sentry/blob/07362b7d8eb6b03acc21aafb91e58a1865c00da3/src/sentry/api/serializers/models/app_platform_event.py#L46-L55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that AppPlatformEvents hits the Gitlab webhook [1] and it does not contain the Gitlab headers. This regression was introduced via #39129.
Fixes SENTRY-W3G
[1]
sentry/src/sentry/api/serializers/models/app_platform_event.py
Lines 46 to 55 in 07362b7