fix(discover): Check for discover-query before requesting homepage#39419
Merged
narsaynorath merged 1 commit intomasterfrom Sep 28, 2022
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
wmak
approved these changes
Sep 28, 2022
narsaynorath
deleted the
nar/fix/discover-homepage-add-discover-query-to-feature-flag-check
branch
ryan953
pushed a commit
that referenced
this pull request
Oct 3, 2022
…39419) `discover-query` is the feature flag that allows users to save queries, so the endpoint is also feature flagged with this. Don't fetch this resource in the frontend if the user doesn't have `discover-query`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discover-queryis the feature flag that allows users to save queries, so theendpoint is also feature flagged with this. Don't fetch this resource in the frontend
if the user doesn't have
discover-query.