feat(replays): New column replayId into the mini events table on the Transaction Summary page#39798
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
jesus4497
commented
Oct 10, 2022
|
|
||
| const StyledIconPlay = styled(IconPlay)` | ||
| position: relative; | ||
| top: -1px; |
Contributor
Author
There was a problem hiding this comment.
With this little tweak the icon gets centered, I believe that due to the font, it doesn't align properly without it
ryan953
reviewed
Oct 11, 2022
ryan953
reviewed
Oct 11, 2022
| replayId: { | ||
| sortField: 'replayId', | ||
| renderFunc: data => { | ||
| const replayId: string | unknown = data?.replayId; |
Member
There was a problem hiding this comment.
Suggested change
| const replayId: string | unknown = data?.replayId; | |
| const replayId = data?.replayId; |
Nit: We shouldn't need to specify types on this variable because the next line does the typeof refinement and we learn that the value is either a string or not.
| ]; | ||
|
|
||
| if (organization.features.includes('session-replay-ui')) { | ||
| transactionsListTitles.push(t('replayid')); |
Member
There was a problem hiding this comment.
Suggested change
| transactionsListTitles.push(t('replayid')); | |
| transactionsListTitles.push(t('replay id')); |
add space to match event id and trace id column headers.
ryan953
added
the
Trigger: getsentry tests
ryan953
approved these changes
Oct 12, 2022
ryan953
added a commit
that referenced
this pull request
Oct 18, 2022
…s tab (#40003) Building from #39798 I've added the same 'replay id' column into the Performance > All Events tab. <img width="1240" alt="Screen Shot 2022-10-13 at 2 57 19 PM" src="https://user-images.githubusercontent.com/187460/195719071-b411b811-39d6-42a2-bf30-f092be6d6a6b.png"> Fixes #39736
barkbarkimashark
pushed a commit
that referenced
this pull request
Oct 18, 2022
…s tab (#40003) Building from #39798 I've added the same 'replay id' column into the Performance > All Events tab. <img width="1240" alt="Screen Shot 2022-10-13 at 2 57 19 PM" src="https://user-images.githubusercontent.com/187460/195719071-b411b811-39d6-42a2-bf30-f092be6d6a6b.png"> Fixes #39736
chadwhitacre
removed
the
Trigger: getsentry tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new column
replayidinside the mini events table on the Transaction Summary pageChanges
Closes #39718
Tests notes
Notes
For the last bullet point
If possible & performant: deep link into the timestamp when the transaction happened.. I will create a follow up PR for this in order to make the PRs smaller.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.