feat(code-owners): remove request to set up codeowners#39897
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
| try { | ||
| addLoadingMessage(t('Requesting\u2026')); | ||
| await this.api.requestPromise( | ||
| `/projects/${organization.slug}/${project.slug}/codeowners-request/`, |
Contributor
There was a problem hiding this comment.
@scefali do you want to make a follow up PR to remove this endpoint? There is no other use for it
NisanthanNanthakumar
approved these changes
Oct 11, 2022
…ove-code-owners-request
github-actions
Bot
added
the
Scope: Backend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
This reverts commit 73137be.
scefali
pushed a commit
that referenced
this pull request
Oct 24, 2022
Removes the backend of requesting to add codeowners. Must be merged after: #39897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folks are complaining about the button for
Request to Set up Codeownerswhich spam everyone in the org who can install an integration even if that user isn't part of the project for the request. We have no data on the impact of it so we should just rip it out.