feat(mobile-exp): Add screenshot gallery tab#39910
Merged
Merged
Conversation
Add feature flag.
github-actions
Bot
added
the
Scope: Frontend
edwardgou-sentry
approved these changes
Oct 12, 2022
edwardgou-sentry
left a comment
edwardgou-sentry
left a comment
Contributor
There was a problem hiding this comment.
just a couple of small things
| import useOrganization from 'sentry/utils/useOrganization'; | ||
|
|
||
| const crashReportTypes = ['event.minidump', 'event.applecrashreport']; | ||
| const screenshotType = 'event.screenshot'; |
Contributor
There was a problem hiding this comment.
small nit but I think we could name this variable in CONSTANT_CASE since it's being used that way
| </LazyLoad> | ||
| </StyledPanelBody> | ||
| </CardBody> | ||
| <CardFooter>{t('screenshot.png')}</CardFooter> |
Contributor
There was a problem hiding this comment.
I think we can get the file name from eventAttachment.name? just in case it's not screenshot.png for whatever reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is behind the
mobile-screenshot-galleryflag.Adds a screenshot tab that displays a gallery of screenshots
Clicking on the cards currently doesn't do anything, it will
be added in a follow up.
Will also add an e2e integration/snapshot test in a follow up.
Note: had to update some components to accept event_id
instead of the entire Event type because the list/gallery
views don't have access the the event detail, only event_ids