feat(hybrid-cloud): Add customer domain support to org switcher#40153
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
dashed
force-pushed
the
hybrid-cloud/customer-domains-org-switcher
branch
from
dd1e6bf to
20bc1f3
Compare
dashed
force-pushed
the
hybrid-cloud/customer-domains-org-switcher
branch
from
20bc1f3 to
e53e97d
Compare
markstory
approved these changes
Oct 19, 2022
markstory
left a comment
markstory
left a comment
Member
There was a problem hiding this comment.
Looks good to me. We can always change the destination of the org-switcher separately.
|
|
||
| const org2Link = screen.getByRole('link', {name: 'org2 Organization 2'}); | ||
| expect(org2Link).toBeInTheDocument(); | ||
| expect(org2Link).toHaveAttribute('href', '/organizations/org2/'); |
Member
There was a problem hiding this comment.
Should we skip a redirect and have the org switcher go to /issues instead?
dashed
force-pushed
the
hybrid-cloud/customer-domains-org-switcher
branch
from
e53e97d to
837702a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds customer domain support to the organization list switcher: