feat(mobile-exp): Paginate through single screenshots in gallery#40260
Merged
Conversation
Paginate through single screenshots in gallery mode.
github-actions
Bot
added
the
Scope: Frontend
Contributor
size-limit report 📦
|
narsaynorath
approved these changes
Oct 20, 2022
Comment on lines
+56
to
+58
| onClick={() => { | ||
| onCursor?.(links.next?.cursor, path, query, 1); | ||
| }} |
Member
There was a problem hiding this comment.
I was wondering if it would be worthwhile to move these onClicks up and have an onPrevious and onNext, might be useful for analytics things but this might be a YAGNI situation.
I just felt like expecting the onCursor to be ready to accept a delta was too specific. I think you'd have to lift up some of the data to get path, query, and links but maybe we have those available in the parent already? Not sure. If there are any issues with this suggestion feel free to ignore it because I think you've clearly denoted this code fits a specific use-case for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paginate through single screenshots in gallery mode.
The pagination buttons are going to change based
on @olivier-w's designs, just want to get the functionality in.