feat(ecosystem): Load integration repos in the background#40361
Merged
Conversation
Instead of showing the spinner until integration repos load, load them in the background and show the spinner inside the dropdown if its still loading.
github-actions
Bot
added
the
Scope: Frontend
scttcper
commented
Oct 20, 2022
Comment on lines
-263
to
-271
| const HeaderText = styled('div')` | ||
| padding-left: ${space(2)}; | ||
| flex: 1; | ||
| `; | ||
|
|
||
| const DropdownWrapper = styled('div')` | ||
| padding-right: ${space(1)}; | ||
| text-transform: none; | ||
| `; |
Member
Author
There was a problem hiding this comment.
none of this really did anything, we had disablePadding on the container and then we added padding to each thing anyway?
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of showing the spinner until integration repos load, load them in the background and show the spinner inside the dropdown if it's still loading.
this is the page being changed
fixes https://getsentry.atlassian.net/browse/WOR-2270