Skip to content

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Sep 7, 2016

@getsentry/javascript


This change is Reviewable

@dcramer
Copy link
Member Author

dcramer commented Sep 7, 2016

I'm envisioning a world where we combine rules + inbound data filters and just create a ton of built-in behavior (like this) that could be opt-in/opt-out.

Until then, I dont think this will break anything. Thoughts?

@dcramer dcramer changed the title Implement react-native filename parsing on server Implement react-native + electron filename parsing on server Sep 7, 2016
@dcramer
Copy link
Member Author

dcramer commented Sep 7, 2016

I need a few Electron examples to confirm, but if its all *.app/Contents/ we can alternatively match that.

@benvinegar
Copy link
Contributor

We should hold off on this until we know what offline app paths look like on Android, Windows, etc.

@dcramer
Copy link
Member Author

dcramer commented Sep 14, 2016

idk how i completely butchered this branch, but will fix

@dcramer dcramer force-pushed the featur/react-native-server branch from 59440cc to 12011ae Compare September 14, 2016 21:18
Copy link
Contributor

@arusakov arusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for Electron support.

@dcramer
Copy link
Member Author

dcramer commented Oct 17, 2016

just a note, need to fix the regexp here yet, but I think we should get this finished up as it greatly simplifies some experiences.

@dcramer
Copy link
Member Author

dcramer commented Oct 27, 2016

@mattrobenolt would you mind taking ownership of this and getting it in?

@dcramer dcramer closed this Mar 27, 2017
@evanpurkhiser evanpurkhiser deleted the featur/react-native-server branch August 16, 2018 22:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants