-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Implement react-native + electron filename parsing on server #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm envisioning a world where we combine rules + inbound data filters and just create a ton of built-in behavior (like this) that could be opt-in/opt-out. Until then, I dont think this will break anything. Thoughts? |
I need a few Electron examples to confirm, but if its all *.app/Contents/ we can alternatively match that. |
We should hold off on this until we know what offline app paths look like on Android, Windows, etc. |
idk how i completely butchered this branch, but will fix |
59440cc
to
12011ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for Electron support.
just a note, need to fix the regexp here yet, but I think we should get this finished up as it greatly simplifies some experiences. |
@mattrobenolt would you mind taking ownership of this and getting it in? |
@getsentry/javascript
This change is