Abstract setuptools asset compiling #4091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Still have to test this actually works for sentry-plugins, but this is the proof of concept |
dcramer
force-pushed
the
feature/abstract-commands
branch
from
bc979b1 to
03ee42c
Compare
Contributor
|
I've verified the output of the Reviewed 1 of 7 files at r1, 9 of 9 files at r2. Comments from Reviewable |
reedloden
reviewed
Oct 9, 2016
| pass | ||
| else: | ||
| log.info('pulled version information from \'{}\''.format( | ||
| self.package_path, |
Contributor
There was a problem hiding this comment.
This should be pkg_path, not package_path.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@getsentry/infrastructure @mitsuhiko
This change is