fix(metrics): Add forward compatibility#41595
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
andriisoldatenko
approved these changes
Nov 21, 2022
jjbayer
approved these changes
Nov 21, 2022
Comment on lines
+70
to
+75
| try: | ||
| # Compatibility fix for new keys "ds::r:1234:e:prod". | ||
| release_id = int(release_id) | ||
| boosted_releases.append((release_id, float(timestamp))) | ||
| except ValueError: | ||
| continue |
Member
There was a problem hiding this comment.
nit: Only guard the section that we expect to fail:
Suggested change
| try: | |
| # Compatibility fix for new keys "ds::r:1234:e:prod". | |
| release_id = int(release_id) | |
| boosted_releases.append((release_id, float(timestamp))) | |
| except ValueError: | |
| continue | |
| try: | |
| # Compatibility fix for new keys "ds::r:1234:e:prod". | |
| release_id = int(release_id) | |
| except ValueError: | |
| continue | |
| else: | |
| boosted_releases.append((release_id, float(timestamp))) |
Member
There was a problem hiding this comment.
Unrelated nit: We convert timestamp to float 2x here.
Contributor
Author
There was a problem hiding this comment.
This was the previous implementation, in the new one we will change that. Thanks for the suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at introducing forward compatibility for the new cache keys
ds::r:1234:prod.