ref(ui) Fix more URLs for customer domains#41715
Merged
Merged
Conversation
* Use new normalizeUrl() method for redirects. * Get organization from context as we won't always have orgId in the params anymore.
markstory
requested review from
a team,
dashed and
davidenwang
and removed request for
dashed
github-actions
Bot
added
the
Scope: Frontend
Contributor
size-limit report 📦
|
dashed
reviewed
Nov 24, 2022
|
|
||
| export default class CreateMonitor extends AsyncView<Props, AsyncView['state']> { | ||
| static contextTypes = { | ||
| router: PropTypes.object, |
Member
There was a problem hiding this comment.
This router context doesn't seem to be used anywhere.
Member
Author
There was a problem hiding this comment.
It isn't used here, but parts of AsyncComponent use router so it needs to be here too.
dashed
reviewed
Nov 24, 2022
|
|
||
| class MonitorDetails extends AsyncView<Props, State> { | ||
| static contextTypes = { | ||
| router: PropTypes.object, |
Member
There was a problem hiding this comment.
This router context doesn't seem to be used anywhere.
Member
Author
There was a problem hiding this comment.
Yeah, it is used by AsyncView/AsyncComponent though.
dashed
approved these changes
Nov 24, 2022
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Fix URL generation in monitors. This was a more invasive change as the routes won't receive `orgId` in the future due to how organization slugs are propagated to class components. * Updated URL normalization for Organization general settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orgIdin the future due to how organization slugs are propagated to class components.