Skip to content

feat(mobile-exp): Track hovers on tag facet bars#41796

Merged
edwardgou-sentry merged 2 commits into
masterfrom
egou/feat/track-tag-facet-hovers
Nov 28, 2022
Merged

feat(mobile-exp): Track hovers on tag facet bars#41796
edwardgou-sentry merged 2 commits into
masterfrom
egou/feat/track-tag-facet-hovers

Conversation

@edwardgou-sentry

Copy link
Copy Markdown
Contributor

Tracks when a user hovers over tag facet bars

@wmak wmak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, lgtm

type: 'bars',
});
}}
onMouseOver={() =>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to debounce this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we should, thanks for pointing out. i was going to do this but forgot lol

@edwardgou-sentry edwardgou-sentry merged commit 69d9e9f into master Nov 28, 2022
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/track-tag-facet-hovers branch November 28, 2022 21:53
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants