Merged
Conversation
github-actions
bot
added
the
Scope: Backend
This attempts to fix how indexer is handling backpressure by keeping track of whether it is in backpressure mode a boolean value `apply_backpressure`. The previous implementation solved the problem by attempting to identify the duplicate values in the batch by their offset number. But it wasn't partition aware so if the batch spans multiple partitions it may have been wrong. This is a required refactor for the upgrade to Arroyo 2.0.0, which will allow messages to represent a batch of values from the broker than might span multliple partitions.
lynnagara
force-pushed
the
arroyo-2.0.0
branch
from
86fcfa9 to
526cf37
Compare
lynnagara
force-pushed
the
arroyo-2.0.0
branch
from
f7444e9 to
bc98391
Compare
jjbayer
approved these changes
Dec 1, 2022
evanh
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #41812
This was performance tested for the metrics indexer in the QA environment. Test speed was roughly the same as before (it was actually slightly faster but the amount was not significant)