fix(dynamic-sampling): Fix edge case of latest release boosting [TET-618]#42488
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
iambriccardo
changed the title
iambriccardo
requested review from
a team,
RaduW and
andriisoldatenko
and removed request for
a team
andriisoldatenko
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing an edge case in which a release is deleted after being boosted. In the previous implementation an error would be thrown. In the new implementation the boosted release will be marked as expired and evicted from Redis when a read is performed through
ProjectBoostedReleases.