fix(domains) Add url normalization to browserHistory.push & router.replace#43120
Merged
Conversation
…place() Update more UI redirects to use customer-domain paths when appropriate.
github-actions
Bot
added
the
Scope: Frontend
Contributor
size-limit report 📦
|
maheskett
approved these changes
Jan 11, 2023
dashed
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update more UI redirects to use customer-domain paths when appropriate. Next I'll take care of browserHistory.replace()
Not all callsites need to be updated. Only callsites where we generate a pathname with a string need to be modified.