Skip to content

feat(file-io): Update issue details with the docs link #43557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged

feat(file-io): Update issue details with the docs link #43557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eaad65
feat(file-io): Update issue details with the docs link
wmak Jan 23, 2023
b85a3a0
Update static/app/components/events/interfaces/performance/utils.tsx
wmak Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions static/app/components/events/interfaces/performance/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const RESOURCES_DESCRIPTIONS: Record<IssueType, string> = {
'N+1 API Calls are repeated concurrent calls to fetch a resource. These spans will always begin at the same time and may potentially be combined to fetch everything at once to reduce server load. Alternatively, you may be able to lazily load the resources. To learn more about how and when to fix N+1 API Calls, check out these resources:'
),
[IssueType.PERFORMANCE_FILE_IO_MAIN_THREAD]: t(
'File IO operations on your main thread may cause app hangs.'
'File IO operations on your main thread may lead to app hangs.'
),
[IssueType.PERFORMANCE_SLOW_DB_QUERY]: t(
'Slow DB Queries are SELECT query spans that take longer than 1s. A quick method to understand why this may be the case is running an EXPLAIN command on the query itself. To learn more about how to fix slow DB queries, check out these resources:'
Expand Down Expand Up @@ -63,7 +63,12 @@ const DEFAULT_RESOURCE_LINK: Record<IssueType, ResourceLink[]> = {
},
],
[IssueType.PERFORMANCE_UNCOMPRESSED_ASSET]: [],
[IssueType.PERFORMANCE_FILE_IO_MAIN_THREAD]: [],
[IssueType.PERFORMANCE_FILE_IO_MAIN_THREAD]: [
{
text: t('Sentry Docs: File IO on the Main Thread'),
link: 'https://docs.sentry.io/product/issues/issue-details/performance-issues/main-thread-io/',
},
],
[IssueType.PERFORMANCE_SLOW_DB_QUERY]: [],
[IssueType.PERFORMANCE_RENDER_BLOCKING_ASSET]: [
{
Expand Down