fix: Remove leading slash from codecov path#43640
Closed
jangjodi wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
the
Scope: Backend
armenzg
approved these changes
Jan 24, 2023
armenzg
left a comment
armenzg
left a comment
Member
There was a problem hiding this comment.
If we want to get a fix quickly let's go for it but I would like tests for this and a way to verify that this is the right fix and understand why this was not a problem yesterday.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codecov coverage for this issue is failing due to the path starting with
/.As shown below, the attempted codecov URL includes a leading
/in front of path.This leading slash is gotten from the stacktrace
sourceRoothere. This does not pose an issue for stacktrace linking, as the leading/is removed here. This PR will remove the leading/from the path in the same way.Failing URL (with leading slash): https://api.codecov.io/api/v2/gh/getsentry/repos/sentry/report?branch=master&path=%2Fsrc%2Fsentry%2Fshared_integrations%2Fclient%2Fbase.py
Correct URL (w/out leading slash): https://api.codecov.io/api/v2/gh/getsentry/repos/sentry/report?branch=master&path=src%2Fsentry%2Fshared_integrations%2Fclient%2Fbase.py