feat(crons): Add monitor slug to APIs #45294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
evanpurkhiser
commented
Mar 2, 2023
evanpurkhiser
commented
- Returns slug as part of the serialized monitor
- Allows slug to be specified for creation and updates
evanpurkhiser
requested review from
a team and
rjo100
and removed request for
a team
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45294 +/- ##
===========================================
+ Coverage 57.10% 80.22% +23.12%
===========================================
Files 4689 4724 +35
Lines 198189 198819 +630
Branches 12006 12007 +1
===========================================
+ Hits 113173 159504 +46331
+ Misses 84754 39053 -45701
Partials 262 262
|
markstory
approved these changes
Mar 2, 2023
rjo100
reviewed
Mar 2, 2023
| class MonitorValidator(serializers.Serializer): | ||
| project = ProjectField(scope="project:read") | ||
| name = serializers.CharField() | ||
| slug = serializers.RegexField(r"^[a-z0-9_\-]+$", max_length=50, required=False) |
There was a problem hiding this comment.
ideally we could move this to a shared constant but probably outside the scope of this PR. just like a ALPHANUMERIC_SLUG_REGEX
There was a problem hiding this comment.
There's a lot of inconsistent slug = serializer.RegexField
| monitor = Monitor.objects.get(id=monitor.id) | ||
| assert monitor.name == "Monitor Name" | ||
|
|
||
| def test_slug(self): |
There was a problem hiding this comment.
worth adding a test where slug is specified but is None or "", I don't think the regex checker will allow it in MonitorValidator. generally we allow None values as equivalent to not specifying an optional param
There was a problem hiding this comment.
Updated. It fails with 'cannot be blank'
dashed
approved these changes
Mar 2, 2023
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-monitor-slug-to-apis
branch
from
139170b to
f13048e
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-monitor-slug-to-apis
branch
from
f13048e to
69481a9
Compare
rjo100
approved these changes
Mar 2, 2023
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-monitor-slug-to-apis
branch
from
69481a9 to
535f4a2
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-monitor-slug-to-apis
branch
from
535f4a2 to
3463d50
Compare
* Returns slug as part of the serialized monitor * Allows slug to be specified for creation and updates
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-monitor-slug-to-apis
branch
from
3463d50 to
93b2f82
Compare
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-add-monitor-slug-to-apis
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.