bug(perf-issues): hook up N+1 Query detection rate again#45380
Merged
Conversation
The `n_plus_one_db_detection_rate` project option was being used to disable N+1 detection on projects with fingerprint issues. At some point the N+1 Query detector stopped respecting that option. Hook it back up, and hook up the MN+1 Query detector to it as well (as they create the same type of issue). If we have a reason in the future to split that option into two, we might, but for now they seem to share fingerprinting issues (typically dynamic custom parent span descriptions). The `n_plus_one_db_issue_rate` project option also disappeared at some point, but we don't need it. This removes the last remnant of it (in project performance settings).
github-actions
Bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
DominikB2014
reviewed
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
n_plus_one_db_detection_rateproject option was being used to disable N+1 detection on projects with fingerprint issues. At some point the N+1 Query detector stopped respecting that option. Hook it back up, and hook up the MN+1 Query detector to it as well (as they create the same type of issue). If we have a reason in the future to split that option into two, we might, but for now they seem to share fingerprinting issues (typically dynamic custom parent span descriptions).