fix(replays): Correctly check for session-replay feature before deciding whether to fetch or show replay onboarding#45871
Conversation
…ing whether to fetch or show replay onboarding
github-actions
Bot
added
the
Scope: Frontend
| isEmpty={replays?.length === 0} | ||
| isLoading={isFetching} | ||
| visibleColumns={visibleColumns} | ||
| data-test-id="replay-table" |
There was a problem hiding this comment.
Why the mix of replay-table and replayTable?
There was a problem hiding this comment.
I started with replayTable then switched to kebab because it seems like the convention.
fixing.
| }); | ||
|
|
||
| return ( | ||
| <Page> |
There was a problem hiding this comment.
nit: you have ReplaysListFetcher wrapping ReplayOnboardingPanel with Page, but have Page here inside of ReplayListTable.
There was a problem hiding this comment.
i think now that ReplaysListFetcher isn't doing much.
I tore it apart because the useReplayList was happening unconditionally, it's in too many bits right now i think
There was a problem hiding this comment.
woah! so much better now. <Page> is no longer a thing ,but there's no duplicate of that stuff.
And just one inner component inside this file.
ryan953
force-pushed
the
ryan953/9821-fix-replay-onboarding-conditions-order
branch
from
a23d0df to
5c51941
Compare
2 participants
Fixes https://github.com/getsentry/getsentry/issues/9821