feat(replay): Reset Network Details when changing filters#46446
Merged
billyvg merged 2 commits intoApr 3, 2023
Conversation
This fixes an issue where you have a filter for fetch requests, view details of first row, clear filter. The URL params for network details persisted through filter changing and so it is trying to view details of the first row in the Network table and will show nothing if it is a non-fetch/xhr row.
github-actions
Bot
added
the
Scope: Frontend
billyvg
commented
Mar 28, 2023
| '' | ||
| ); | ||
| const {getParamValue: getDetailTab} = useUrlParams('n_details_tab', 'request'); | ||
| const {getParamValue: getDetailTab} = useUrlParams('n_detail_tab', 'request'); |
Member
Author
There was a problem hiding this comment.
I changed this to make it consistent with n_detail_row
eliashussary
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where you have a filter for fetch requests, view details of first row, clear filter. The URL params for network details persisted through filter changing and so it is trying to view details of the first row in the Network table and will show nothing if it is a non-fetch/xhr row.