test(ui): Set environment on master branch + CI#46547
Merged
Conversation
CI data can be messy since it includes everyone's PR's. This would reduce sampling for the master branch by setting the environment to production and reducing the sample rate for the dev environment.
scttcper
changed the title
mattgauntseo-sentry
approved these changes
Mar 29, 2023
Contributor
mattgauntseo-sentry
left a comment
mattgauntseo-sentry
left a comment
There was a problem hiding this comment.
Overall love this change as making sense of the data in the javascript project is tough without this.
I've been using the branch tag, but it seems like this isn't going to work for alerting in the near future.
billyvg
reviewed
Mar 29, 2023
| tracesSampleRate: 1, | ||
| // Use production env to reduce sampling of commits on master | ||
| environment: CI ? (IS_MASTER_BRANCH ? 'ci:master' : 'ci:pull_request') : 'local', | ||
| tracesSampleRate: CI ? 1 : 0.5, |
Member
There was a problem hiding this comment.
Do we want to change sample rate by CI or IS_MASTER_BRANCH?
Member
Author
There was a problem hiding this comment.
attempting to prioritize CI for now by sending fewer in dev/local. but i might do that too
scttcper
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI data can be messy since it includes everyone's PR's that may or may not be up to date. Filtering by branch samples the data.
This would reduce sampling for the master branch by setting the environment to production and reducing the sample rate for the dev environment.