drop foreign key constraint on project_id for release and releasefile#4765
Merged
Conversation
Contributor
Generated by 🚫 danger |
mattrobenolt
approved these changes
Jan 13, 2017
mattrobenolt
left a comment
mattrobenolt
left a comment
Contributor
There was a problem hiding this comment.
if tests pass, should be fine
mattrobenolt
suggested changes
Jan 13, 2017
|
|
||
| # Changing field 'ReleaseFile.project_id' | ||
| db.execute("ALTER TABLE sentry_releasefile DROP CONSTRAINT project_id_refs_id_878696ea") | ||
| elif is_mysql(): |
Contributor
There was a problem hiding this comment.
From testing locally, it appears that the project_id FK constraints don't exist, so we can ignore anything for MySQL. I confirmed this on both sentry_release and sentry_releasefile.
| def forwards(self, orm): | ||
| if is_postgres(): | ||
| # Changing field 'Release.project_id' | ||
| db.execute("ALTER TABLE sentry_release DROP CONSTRAINT project_id_refs_id_21d237e2") |
Contributor
There was a problem hiding this comment.
Might as well add a IF EXISTS in here so it doesn't error just in case something fishy happened.
ALTER TABLE sentry_release DROP CONSTRAINT IF EXISTS project_id_refs_id_21d237e2
added 2 commits
January 13, 2017 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#nochanges