Skip to content

fix(search): fallback to searching for errors if the bulk search across multiple datasets fails#48310

Merged
wedamija merged 2 commits into
masterfrom
sharky/issue-search-fallback
May 8, 2023
Merged

fix(search): fallback to searching for errors if the bulk search across multiple datasets fails#48310
wedamija merged 2 commits into
masterfrom
sharky/issue-search-fallback

Conversation

@barkbarkimashark

Copy link
Copy Markdown
Contributor

The search code fans-out and searches multiple datasets if the search criteria calls for it. But someones we encounter errors in the search when targetting the issue platform dataset and it errors the entire issue search. Instead, we should attempt the search, and fallback to only searching the errors dataset when we encounter an error.

@barkbarkimashark barkbarkimashark requested a review from a team as a code owner May 2, 2023 00:13
@barkbarkimashark barkbarkimashark requested a review from a team May 2, 2023 00:13
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 2, 2023
@codecov

codecov Bot commented May 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #48310 (7af2f46) into master (18f867f) will increase coverage by 5.36%.
The diff coverage is 84.78%.

❗ Current head 7af2f46 differs from pull request most recent head 00164b8. Consider uploading reports for the commit 00164b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #48310      +/-   ##
==========================================
+ Coverage   75.51%   80.87%   +5.36%     
==========================================
  Files        4771     4772       +1     
  Lines      201807   201850      +43     
  Branches    11524    11524              
==========================================
+ Hits       152385   163255   +10870     
+ Misses      49167    38340   -10827     
  Partials      255      255              
Impacted Files Coverage Δ
src/sentry/conf/server.py 93.75% <ø> (ø)
src/sentry/search/snuba/executors.py 85.30% <50.00%> (-9.72%) ⬇️
src/sentry/tasks/auto_ongoing_issues.py 95.65% <91.30%> (+52.31%) ⬆️
src/sentry/features/__init__.py 100.00% <100.00%> (ø)
src/sentry/issues/ongoing.py 100.00% <100.00%> (ø)

... and 603 files with indirect coverage changes

@evanh evanh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the issue platform query fail?

@wedamija wedamija merged commit 2b59f69 into master May 8, 2023
@wedamija wedamija deleted the sharky/issue-search-fallback branch May 8, 2023 19:42
@wedamija

wedamija commented May 9, 2023

Copy link
Copy Markdown
Member

Why does the issue platform query fail?

This is more of a safety net when we have incompatible queries. They can fail for various reasons, usually cases where we have a mismatch between schemas, but sometimes it's when a filter just doesn't apply to the issue platform but we didn't account for it, so we end up erroring. Ideally we see these problems and fix them properly, but this allows us to avoid breaking the issue stream in the mean time.

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants