feat(replays): Add a note about cross-origin (CDN) Replay Network request status codes#48640
Merged
Merged
Conversation
…uest status codes
github-actions
Bot
added
the
Scope: Frontend
billyvg
reviewed
May 5, 2023
billyvg
approved these changes
May 5, 2023
JonasBa
reviewed
May 5, 2023
Member
Author
|
Added a bunch of other copy changes to make things more consistent in this area. |
billyvg
approved these changes
May 5, 2023
ryan953
force-pushed
the
ryan953/replay-network-cached-assets
branch
from
9ff3586 to
f4be952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of
0in the status column now, but the tooltip provides some new tips for how to improve things.Also, blank cells (in all columns) show
--now instead of being blank. There are not that many blank cells overall.For Reference: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/responseStatus#cross-origin_response_status_codes
Relates to https://github.com/getsentry/team-replay/issues/35
Other copy changes, and switching from
<kbd>to<code>looks like this: