feat(starfish): Add endpoint returns series for top 5 facets#48665
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
shruthilayaj
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48665 +/- ##
==========================================
+ Coverage 80.94% 80.96% +0.01%
==========================================
Files 4780 4781 +1
Lines 201784 201920 +136
Branches 11450 11450
==========================================
+ Hits 163333 163483 +150
+ Misses 38196 38182 -14
Partials 255 255
|
wmak
approved these changes
May 8, 2023
Comment on lines
+408
to
+410
| count_column = "count_range({condition}, {boundary})" | ||
| count_range_1 = tag_query.resolve_function( | ||
| count_column.format(condition="lessOrEquals", boundary=middle), |
Member
There was a problem hiding this comment.
Suggested change
| count_column = "count_range({condition}, {boundary})" | |
| count_range_1 = tag_query.resolve_function( | |
| count_column.format(condition="lessOrEquals", boundary=middle), | |
| count_range_1 = tag_query.resolve_function( | |
| f"count_range(lessOrEquals, {middle})", |
| tag_key = TAG_ALIASES.get(tag_key) | ||
|
|
||
| with sentry_sdk.start_span(op="discover.endpoint", description="discover_query"): | ||
| referrer = "api.organization-events-facets-stats-performance.top-tags" |
Member
There was a problem hiding this comment.
Should use the referrer module in snuba,
ie. from sentry.snuba.referrer import Referrer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also return count delta to maybe allow us to prioritize
the facet that has had an increase in throughput (in the
case of a regression caused by a sudden increase in a certain
facet)
Series will be used to show sparklines in the frontend