Skip to content

disable caching on integration details endpoint#48728

Merged
mdtro merged 1 commit into
masterfrom
mdtro/integration-detail-no-cache
May 8, 2023
Merged

disable caching on integration details endpoint#48728
mdtro merged 1 commit into
masterfrom
mdtro/integration-detail-no-cache

Conversation

@mdtro

@mdtro mdtro commented May 8, 2023

Copy link
Copy Markdown
Contributor

The details and configuration pages of integrations can potentially contain sensitive data. This instructs the client browser to not cache the responses.

This is a best effort at preventing this data from being cached. Browsers will generally honor this, but proxy devices between the client and server are free to ignore the cache header and cache the responses (as they often do).

Ticket: INFO-161

@mdtro mdtro requested a review from a team May 8, 2023 20:06
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 8, 2023
@codecov

codecov Bot commented May 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #48728 (0dcfbb9) into master (df37683) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #48728      +/-   ##
==========================================
- Coverage   80.97%   80.96%   -0.01%     
==========================================
  Files        4781     4781              
  Lines      201897   201908      +11     
  Branches    11449    11449              
==========================================
- Hits       163484   163482       -2     
- Misses      38158    38171      +13     
  Partials      255      255              
Impacted Files Coverage Δ
...e/transactionSummary/transactionEvents/content.tsx 78.78% <ø> (ø)
.../integrations/organization_integrations/details.py 92.64% <100.00%> (+0.58%) ⬆️

... and 4 files with indirect coverage changes

@mdtro mdtro merged commit 94beefe into master May 8, 2023
@mdtro mdtro deleted the mdtro/integration-detail-no-cache branch May 8, 2023 22:44
scttcper added a commit that referenced this pull request Jun 1, 2023
Adds `referrer-policy: strict-origin-when-cross-origin` to the integration endpoints. Related to #48728

fixes https://getsentry.atlassian.net/browse/WOR-3006
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants